-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Knapsacp algorithm in dynamic algorithm #1277
Conversation
@Panquesito7
|
@Panquesito7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: rename the vars
update Knapsacp.c
Co-authored-by: David Leal <[email protected]>
Co-authored-by: David Leal <[email protected]>
tests() -> test() rename
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing! ❤️
Co-authored-by: realstealthninja <[email protected]>
Co-authored-by: realstealthninja <[email protected]>
Co-authored-by: realstealthninja <[email protected]>
I wanted to inform you that I've made some updates, which automatically dismissed the previous approval. The latest commit (commit hash: 8ca58f0) includes changes, such as adding comments for clarification. I kindly request your review once again to provide your valuable feedback on the latest changes. Thank you and best regards :)! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks absolutely wonderful! ❤️
Co-authored-by: David Leal <[email protected]>
Co-authored-by: David Leal <[email protected]>
Co-authored-by: David Leal <[email protected]>
Co-authored-by: David Leal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there are a lot of errors here: https://github.com/TheAlgorithms/C/actions/runs/5652143546/job/15350288419?pr=1277#step:3:672
Please fix those. Let us know if you need any help with that. 🙂
Hi @Panquesito7 I noticed that in line 36-37 of the 'Item' struct, direct member initialization within the struct is not supported in standard C language. so fixed that line. Thank you :)! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. Thank you! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great just a small nitpick
Co-authored-by: realstealthninja <[email protected]>
fa39b11
Co-authored-by: realstealthninja <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me!
Hi @tjgurwara99, Could you please review this PR, when you have a moment ? Your attention to this matter is greatly appreciated. Thank you:) |
This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Please ping one of the maintainers once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to ask for help in our Gitter channel or our Discord server. Thank you for your contributions! |
Description of Change
Hi. I have added the knapsack(0-1 knapsack)algorithm code to dynamic programming.
References
Checklist
Notes: